Skip to content

rsa pki encoding/decoding tests and fix for encoding rsapss to pki#333

Merged
ColtonWilley merged 1 commit intowolfSSL:masterfrom
sebastian-carpenter:encode-decode-tests
Feb 2, 2026
Merged

rsa pki encoding/decoding tests and fix for encoding rsapss to pki#333
ColtonWilley merged 1 commit intowolfSSL:masterfrom
sebastian-carpenter:encode-decode-tests

Conversation

@sebastian-carpenter
Copy link
Contributor

@sebastian-carpenter sebastian-carpenter commented Nov 21, 2025 •
edited
Loading

This mainly contains testing for encoding / decoding RSA and RSASSA-PSS keys to / from pki.

Found some bugs and fixed them:

  • RSASSA-PSS key params are not encoded to DER when using pki encoding. Copied some code from the spki encoding section for a fix (altered it slightly for different offsets).
  • WolfProvider returns digest names that do not match those of OSSL. Made a mapping function based on a wolfcrypt enum.

Addendum:

  • When doing the encoding test the created der was then decoded with ossl and wp. Changed test_rsa_decode_pkcs8_evp_pkey to allow decoding ctx to be specified. Now decoding can be done with ossl and wp, or just ossl.

@sebastian-carpenter sebastian-carpenter self-assigned this Nov 21, 2025
SparkiDev
SparkiDev requested changes Nov 23, 2025
View reviewed changes
Copy link
Contributor

@SparkiDev SparkiDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does wp_rsa_import have a parameter with a string that is the wrong name form?
We have places we set mdName to something explicitly and they can be changed but the import should be the same as

@sebastian-carpenter
Copy link
Contributor Author

sebastian-carpenter commented Nov 25, 2025

Why does wp_rsa_import have a parameter with a string that is the wrong name form? We have places we set mdName to something explicitly and they can be changed but the import should be the same as

comment seems cut off so I took my best guess. I didn't do anything to wp_rsa_import so I'm thinking this is meant to refer to wp_digest_to_ossl_digest. Previously the parameter was ossl_digest so I changed it to osslDigest in the rebase.

As for why this functions exists: When you get parameters from wolfProvider the md and mgf should match what OpenSSL uses for their digest names. I didn't edit what the md and mgf were set to in wolfProvider since it seems like that could cause issues in wolfCrypt (though I'm not certain).

@ColtonWilley ColtonWilley merged commit 4eeea87 into wolfSSL:master Feb 2, 2026
370 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ColtonWilley ColtonWilley ColtonWilley approved these changes

@SparkiDev SparkiDev SparkiDev approved these changes

@aidangarske aidangarske Awaiting requested review from aidangarske

@padelsbach padelsbach Awaiting requested review from padelsbach

Assignees

@sebastian-carpenter sebastian-carpenter

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sebastian-carpenter @ColtonWilley @SparkiDev